-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attach container stdin on tutor dev start <service> #1152
Merged
kdmccormick
merged 6 commits into
overhangio:release
from
edly-io:danyalfaheem/add-dev-attach-command
Dec 10, 2024
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
caa6e0b
fix: attach container stdin on tutor dev start <service>
Danyal-Faheem ed4da20
fix: format files
Danyal-Faheem d76b350
docs: update changelog entry
Danyal-Faheem 49100df
docs: update changelog entry
Danyal-Faheem f4ec484
fix: handle comments
Danyal-Faheem 9c9d49b
fix: format files
Danyal-Faheem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
changelog.d/20241205_211837_danyal.faheem_add_dev_attach_command.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- [Bugfix] Fix breakpoint debugging by attaching container stdin when running tutor dev start <service> for a single <service>. (by @Danyal-Faheem) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -245,14 +245,22 @@ def start( | |
services: list[str], | ||
) -> None: | ||
command = ["up", "--remove-orphans"] | ||
attach = len(services) == 1 | ||
if build: | ||
command.append("--build") | ||
if detach: | ||
# We have to run the container in detached mode first to attach to it | ||
if detach or attach: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the comment 😂 |
||
command.append("-d") | ||
|
||
# Start services | ||
config = tutor_config.load(context.root) | ||
context.job_runner(config).docker_compose(*command, *services) | ||
if attach and not detach: | ||
fmt.echo_info( | ||
f"""Attaching to service {services[0]} | ||
Danyal-Faheem marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ℹ️ To detach without stopping the service, use ctrl+p followed by ctrl+q""" | ||
) | ||
context.job_runner(config).docker_compose("attach", *services) | ||
|
||
|
||
@click.command(help="Stop a running platform") | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we can simplify the code slightly by writing:
attach = len(services) == 1 and not detach
Then below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great suggestion, I've made the change.