Enhancement: add support for consuming events from event bus in discovery #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Faraz32123
commented
Jan 8, 2025
Faraz32123
commented
- add support to consume events from event bus in discovery. Explanation can be viewed here: https://github.com/openedx/event-bus-redis/blob/main/docs/tutor_installation.rst
- close Systems libraries missing for event bus use? #94
- add support to consume events from event bus in discovery. Explanation can be viewed here: https://github.com/openedx/event-bus-redis/blob/main/docs/tutor_installation.rst - close overhangio#94
changelog.d/20250108_184343_faraz.maqsood_add_support_for_consuming_events_from_event_bus.md
Outdated
Show resolved
Hide resolved
DawoudSheraz
reviewed
Jan 8, 2025
changelog.d/20250108_184343_faraz.maqsood_add_support_for_consuming_events_from_event_bus.md
Outdated
Show resolved
Hide resolved
Faraz32123
force-pushed
the
feat/add_support_for_consuming_events_from_event_bus
branch
from
9459e26 to
df9043c
Compare
DawoudSheraz
reviewed
Jan 9, 2025
README.rst
Outdated
| @@ -201,6 +201,16 @@ This entry may be present if you named your server with the LMS hostname. | |||
|
|
|||
| .. _DigitalOcean: https://digitalocean.com/ | |||
|
|
|||
|
|
|||
| Use event-bus through tutor-discovery | |||
There was a problem hiding this comment.
nit: Using event-bus with tutor-discovery
DawoudSheraz
reviewed
Jan 9, 2025
README.rst
Outdated
| Use event-bus through tutor-discovery | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Event bus can be run through discovery. To consume events from event bus in discovery, follow these `instructions`_ provided by `event-bus-redis`_. |
There was a problem hiding this comment.
We can mention that tutor-discovery does not start event bus consumption by default but supports running it. And if someone wants to, they can do so by following the doc/link.
DawoudSheraz
approved these changes
Jan 9, 2025
Faraz32123
force-pushed
the
feat/add_support_for_consuming_events_from_event_bus
branch
from
662aa61 to
bab86d2
Compare
Faraz32123
deleted the
feat/add_support_for_consuming_events_from_event_bus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.