feat: add startTransaction to library

This feature never received any feedback ¯\_(ツ)_/¯
overextended · Oct 1, 2024 · 5b76dcb · 5b76dcb
1 parent 287542d
commit 5b76dcb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/lib/MySQL.lua b/lib/MySQL.lua
@@ -148,4 +148,8 @@ MySQL.ready = setmetatable({
 	end,
 })
 
+function MySQL.startTransaction(cb)
+	return oxmysql:startTransaction(cb, resourceName)
+end
+
 _ENV.MySQL = MySQL
diff --git a/lib/MySQL.ts b/lib/MySQL.ts
@@ -44,6 +44,9 @@ interface OxMySQL {
   transaction: (query: Transaction, params?: Params | Callback<boolean>, cb?: Callback<boolean>) => Promise<boolean>;
   isReady: () => boolean;
   awaitConnection: () => Promise<true>;
+  startTransaction: (
+    cb: (query: <T = Result | null>(statement: string, params?: Params) => Promise<T>) => Promise<boolean | void>
+  ) => Promise<boolean>;
 }
 
 const QueryStore: string[] = [];
@@ -158,4 +161,7 @@ export const oxmysql: OxMySQL = {
   async awaitConnection() {
     return await exp.awaitConnection();
   },
+  async startTransaction(cb) {
+    return exp.experimentalTransaction(cb, currentResourceName);
+  },
 };
diff --git a/src/index.ts b/src/index.ts
@@ -78,17 +78,13 @@ MySQL.transaction = (
   rawTransaction(invokingResource, queries, parameters, cb, isPromise);
 };
 
-global.exports(
-  'experimentalTransaction',
-  async (
-    transactions: () => Promise<boolean>,
-    cb: CFXCallback,
-    invokingResource = GetInvokingResource(),
-    isPromise?: boolean
-  ) => {
-    return await startTransaction(invokingResource, transactions, cb, isPromise);
-  }
-);
+MySQL.startTransaction = (
+  transactions: () => Promise<boolean>,
+  invokingResource = GetInvokingResource()
+) => {
+  console.warn(`MySQL.startTransaction is "experimental" and may receive breaking changes.`)
+  return startTransaction(invokingResource, transactions, undefined, true);
+};
 
 MySQL.prepare = (
   query: string,