fix(resource/menu): prevent opening empty menu #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is a thing that should be handled, I've unfortunately done this myself on accident a lot and spent too much time figuring out why it doesn't open, only for the nui code to be broken and a restart fixing it. |
|
We probably need to look into resolving the underlying issue of the app breaking when there's an error, assuming that isn't a difficult task. At the very least we should be able to log the nui events causing issues if not revert the state/cancel the action. |
thelindat
added a commit
that referenced
this pull request
Dec 6, 2024
Prevents the app from failing on render errors as mentioned in #675. More to come..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening an empty menu always leads to an error and the nui code breaking. This should prevent most cases (as there can still be people that send empty tables in the options).