Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates eligibility rules #480

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

abhiprojectz
Copy link
Contributor

This fixes #473

It updates the eligibility rules

@sagesharp sagesharp merged commit 52df3dd into outreachy:master Jul 23, 2021
@sagesharp
Copy link
Collaborator

Thanks for working on this, @abhiprojectz! This is a great commit with exactly what the issue asked for.

Note that in the future, if you include one line in the body of your commit message "Fixes #473", then GitHub will automatically close that issue when the pull request is merged. That means you can put a more readable comment in the first line of your commit, like "Clarify eligibility rules for people with jobs".

The reason that's important is because the first line of your commit message ends up being shown in tools, and the rest of the commit message will be hidden. The first line is displayed in tools like gitk or when you run git log --oneline, or when you run git rebase -i. So it's very important that the first line of your git commit message explain what you are doing without someone needing to reference the GitHub issue number.

If you want to take on future tasks in the Outreachy repo, I suggest taking ones marked newcomers-welcome or help-wanted. Rosanne is working on some tasks, so I'll try to make sure to assign her to the ones she's currently working on.

@abhiprojectz
Copy link
Contributor Author

@sagesharp Thank you, i didn't knew this before. I'll take care of the commit messages from next time while making a pull request.
Also , one of my #481 PR is ready to review, maybe it can help in project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify eligibility WRT employment
2 participants