Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disabled attribute when readonly property is true #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scouser03
Copy link

No description provided.

@marttinnotta
Copy link

marttinnotta commented Feb 23, 2023

Hi and thank you for your contribution!

Readonly and disabled property have different purposes and should not be mixed like that. While readonly prevents user from editing the field disabled state will in some browser remove event listeners entirely from input.

I suggest to change your code so that instead of disabled state use readonly state instead and don't allow toggling picker when it's in readonly mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants