In Archetype Delete, call PatchMeta. Fixes https://github.com/outfox/fennecs/issues/23 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see contributor guidelines, I've only been looking at fennecs source code for a few hours, and I don't regularly contribute to open source, so please let me know if there's something I should do differently. There's one TODO comment that needs to be addressed. I wasn't sure where to put the new unit test. |
PennyMew
commented
Sep 22, 2024
| /// Meta within the World will have the correct Row to access the Entity's associated data | ||
| /// within the Archetype. | ||
| /// </summary> | ||
| /// <param name="entry">If `count` param is nonzero, `entry` must be less than `this.Count`.</param> |
There was a problem hiding this comment.
Technically should replace "nonzero" with "greater than zero"
|
Holy moly, indeed. Let me verify this. |
|
Thank you so very much for providing this vital fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.