Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Return with CORS headers #81

Merged
merged 1 commit into from
Jan 29, 2025
Merged

bug: Return with CORS headers #81

merged 1 commit into from
Jan 29, 2025

Conversation

Brayden
Copy link
Member

@Brayden Brayden commented Jan 29, 2025

Purpose

Previous PR was returning the /_internal/stats endpoint without the proper CORS headers attached to the response.

Tasks

  • Return results with prebuilt createResponse function

Verify

Before

After

@Brayden Brayden self-assigned this Jan 29, 2025
@Brayden Brayden added the bug Something isn't working label Jan 29, 2025
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 2.07% (🎯 75%) 21 / 1010
🔴 Statements 1.98% (🎯 75%) 21 / 1057
🔴 Functions 2.99% (🎯 75%) 5 / 167
🔴 Branches 0% (🎯 75%) 0 / 594
File CoverageNo changed files found.
Generated in workflow #52 for commit 7b5d2a4 by the Vitest Coverage Report Action

@Brayden Brayden merged commit 5f5e580 into main Jan 29, 2025
1 check passed
@Brayden Brayden deleted the bwilmoth/internal-stats branch January 29, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Brayden Brayden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Brayden