Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX/ROS-382: os_driver fails when raw option is enabled #384

Merged

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Oct 8, 2024

Related Issues & PRs

Summary of Changes

  • Fix os_driver _fails_when_raw_option_is_enabled
  • Replace lifecycle_publisher with regular publisher for the os_pcap

Validation

  • Adding a RAW token to the proc_mask doesn't brick the driver.
ros2 launch ouster_ros driver.launch.xml ... proc_mask:="PCL|RAW"

@Samahu Samahu added the bug Something isn't working label Oct 8, 2024
@Samahu Samahu self-assigned this Oct 8, 2024
@Samahu Samahu changed the title HOTFIX/ROS-382-os_driver_fails_when_raw_option_is_enabled HOTFIX/ROS-382-os_driver fails when raw option is enabled Oct 8, 2024
@Samahu Samahu marked this pull request as ready for review October 8, 2024 15:11
@Samahu Samahu changed the title HOTFIX/ROS-382-os_driver fails when raw option is enabled HOTFIX/ROS-382: os_driver fails when raw option is enabled Oct 8, 2024
Copy link
Collaborator

@matthew-lidar matthew-lidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Samahu Samahu merged commit 78c96fa into ros2 Oct 8, 2024
4 checks passed
@Samahu Samahu deleted the HOTFIX/ROS-382-os_driver_fails_when_raw_option_is_enabled branch October 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants