Move factory upgrade gate to seperate contract #200

iainnash · 2023-09-26T19:57:09Z

Moves upgrade gate to a standalone immutable ownable contract.

…#144) * reduce optimizer runs to get contracts to build * Premint V2 - Creator Attribution (#128) * wip on move premint to creator attribution style * updated readme to reflect new contracts * Revert "undo changes to js sdk" This reverts commit 4deabf5. * better comments * Added methods to get status of creator attribution, and validate signatures, useful for the backend * better comments * fixed back fork test * slightly more comments

Created a release

* * Check if key exists reading an address, as to not result in unexpected reverts * In premint tests, allow all forks to run the tests, but skip if there is no address for preminter * update storage layout

* Creator attribution - add creator to event * * Renamed creator attribution args from bytes32 to string to match the standard * Added test that verifies creator attribution event emitted

* refactor: remove legacy mint fee contracts * refactor: remove unusued import * chore: update tests * chore: lint * chore: update runs * chore: update storage layout * style: update natspec * chore: update tests * chore: remove unused var * chore: update tests * fix: move hardcoded fork vars to constants * added first minter changeset * * Added changeset that depreates redeem minters. * Remove Redeem minter from coverage. --------- Co-authored-by: Rohan Kulkarni <[email protected]>

Moved some common factory setup logic to some library fixtures

…mint contract (#170)

…ersion. Will do updates via the standard changeset way

iainnash · 2023-09-26T19:57:30Z

Current dependencies on/for this PR:

main
- PR Fix published package to properly reference types #193
  - PR Prerelease workflow for versioning + publishing prerelease tags #184
    - PR Premint #161
      - PR refactor: only mint if specified quantity is greater than 0 #212
      - PR refactor: implement first minter reward on adminMint #207
        
        PR refactor: remove mint fee amount deploy param #208
      - PR refactor: add helper to read uups implementation #206
      - PR fix: redeem minter tests #203
      - PR move factory to a standalone contract #202
      - PR Move factory upgrade gate to seperate contract #200 👈
      - PR Premint: updated documentation #199
      - PR Add back mint fee getter #198
      - PR Premint - upgradeable premint, new deployment scripts, and premint proxy deployment #189
        
        PR Premint - expose preminter via js sdk #190
        
        PR Premint - factory proxy 777 deployments #191
        
        PR Premint prerelease #187
      - PR Premint - move delegated minter state to its own contract #188
      - PR Prerelease workflow for versioning + publishing prerelease tags #179
        
        PR Premint - proxy deployment and updated deployment scripts #171
        
        PR Update deployment instructions #183
        
        PR Prerelease ci task #178
        
        PR Expose preminter from package #175
        
        PR Premint: pre-release #173
        
        PR Premint: 1.5.0-gasless release #172
      - PR Premint - include erc1155 errors in premint executor abi, by extracting its errors into interface and importing it #170
      - PR Premint - premint executor is upgradeable #168
        
        PR Premint - wrap erc1155 errors in an error that can be decoded - Erc1155CallReverted(bytes errorRevertedData) #169
      - PR Premint - move attribution lib to contract consumed via interface #166
      - PR Premint: fix fork tests #164
      - PR Premint: add creator to creator attribution event #163
      - PR Premint: first minter rewards #162

This comment was auto-generated by Graphite.

* Create pull_request_template.md * update re dan comments

oveddan and others added 26 commits September 26, 2023 15:52

Added pre-release ci task

fc03bc4

upgrade viem

bfa89f3

Gasless

c41b185

fix hanging test

d1634ed

prettier fix

0c9f103

Creator attribution deployed contracts

4d55bc1

hack - only test fork on zora goerli for premint

909b6a0

deployed new creator attribution

a04075c

Created a release

fix: factory tests

d8c871c

chore: remove alt deploy script

f008708

refactor: early return token id if token exists

faa75ba

refactor: store 1155 factory as immutable

0e15997

chore: update tests

e5dbd37

chore: update tests

257c22d

chore: lint

fb5df44

Premint: fix fork tests (#164)

076025a

* * Check if key exists reading an address, as to not result in unexpected reverts * In premint tests, allow all forks to run the tests, but skip if there is no address for preminter * update storage layout

Premint: add creator to creator attribution event (#163)

b00372a

* Creator attribution - add creator to event * * Renamed creator attribution args from bytes32 to string to match the standard * Added test that verifies creator attribution event emitted

fix coverage compilation issue

fc8bfb1

filter coverage files to ignore

e533606

Made premint executor upgradeable via a proxy. (#168)

5813116

Moved some common factory setup logic to some library fixtures

Extracted erc1155 errors to an interface, and importing that into pre…

55e821e

…mint contract (#170)

Reverted manual premint version update, and just pointing to origin v…

8dd51cf

…ersion. Will do updates via the standard changeset way

fix: read fee from config for fork test

7b43696

Update factory and tests

9c8ed96

This was referenced Sep 26, 2023

Fix published package to properly reference types #193

Merged

Prerelease workflow for versioning + publishing prerelease tags #184

Merged

Premint #161

Merged

Premint: first minter rewards #162

Merged

oveddan force-pushed the premint branch from 7b43696 to 068989e Compare September 26, 2023 21:07

ourzora deleted a comment from iainnash Sep 26, 2023

iainnash mentioned this pull request Sep 26, 2023

move factory to a standalone contract #202

Closed

iainnash closed this Sep 26, 2023

iainnash deleted the 09-26-Update_factory_and_tests branch January 11, 2024 15:37

iainnash added a commit that referenced this pull request Mar 11, 2024

Create pull_request_template.md (#200)

ef2a8a1

* Create pull_request_template.md * update re dan comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move factory upgrade gate to seperate contract #200

Move factory upgrade gate to seperate contract #200

iainnash commented Sep 26, 2023

iainnash commented Sep 26, 2023 •

edited by kulkarohan

Loading

Move factory upgrade gate to seperate contract #200

Move factory upgrade gate to seperate contract #200

Conversation

iainnash commented Sep 26, 2023

iainnash commented Sep 26, 2023 • edited by kulkarohan Loading

iainnash commented Sep 26, 2023 •

edited by kulkarohan

Loading