Premint prerelease #180
Closed
Premint prerelease #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#144) * reduce optimizer runs to get contracts to build * Premint V2 - Creator Attribution (#128) * wip on move premint to creator attribution style * updated readme to reflect new contracts * Revert "undo changes to js sdk" This reverts commit 4deabf5. * better comments * Added methods to get status of creator attribution, and validate signatures, useful for the backend * better comments * fixed back fork test * slightly more comments
Created a release
* * Check if key exists reading an address, as to not result in unexpected reverts * In premint tests, allow all forks to run the tests, but skip if there is no address for preminter * update storage layout
* Creator attribution - add creator to event * * Renamed creator attribution args from bytes32 to string to match the standard * Added test that verifies creator attribution event emitted
* refactor: remove legacy mint fee contracts * refactor: remove unusued import * chore: update tests * chore: lint * chore: update runs * chore: update storage layout * style: update natspec * chore: update tests * chore: remove unused var * chore: update tests * fix: move hardcoded fork vars to constants * added first minter changeset * * Added changeset that depreates redeem minters. * Remove Redeem minter from coverage. --------- Co-authored-by: Rohan Kulkarni <[email protected]>
Moved some common factory setup logic to some library fixtures
…ersion. Will do updates via the standard changeset way
This was referenced Sep 18, 2023
Merged
Merged
This was referenced Sep 18, 2023
Closed
Closed
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
oveddan
force-pushed
the
prerelease-action
branch
from
54394fb
to
d3ba9a0
Compare
oveddan
force-pushed
the
premint-prerelease
branch
from
65c2191
to
cf57e96
Compare
oveddan
force-pushed
the
prerelease-action
branch
from
d3ba9a0
to
a293771
Compare
oveddan
force-pushed
the
premint-prerelease
branch
from
cf57e96
to
54ecff8
Compare
* Extracted common deployment tasks to reusable helper functions
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
oveddan
force-pushed
the
prerelease-action
branch
from
a293771
to
74b9307
Compare
oveddan
changed the base branch from
prerelease-action
to
premint-export-preminter-from-package
oveddan
force-pushed
the
premint-prerelease
branch
from
54ecff8
to
3ed269f
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
oveddan
changed the base branch from
premint-export-preminter-from-package
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.