signature minting with auth registry #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveddan
reviewed
Aug 14, 2023
| keccak256( | ||
| "Mint(address target,address signer,address to,uint256 quantity,uint256 totalPrice,uint256 nonce,uint256 deadline)" | ||
| "Mint(address target,bytes32 nonce,uint256 quantity,uint256 totalPrice,uint256 expiration,address mintTo)" |
There was a problem hiding this comment.
this name of Mint differs from that on the erc1155SignatureMinter: https://github.com/ourzora/zora-drops-extensions/pull/10/files#diff-eb732028f44eaa01072f29653b17a96d03c39f0fc4f46bd7f060ea7debbce037R68
Ideally they'd have the same name, either requestMint or Mint
There was a problem hiding this comment.
@oveddan requestMint is an IMinter1155 convention that we dont use anywhere in drops / this repo. id rather keep it Mint but if you prefer i'll change it
There was a problem hiding this comment.
fine to keep as is if you think thats best, just wanted to flag it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.