[back 2727] Library usage example #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikreppel
force-pushed
the
erik/back-2727-rule-api-customization-example
branch
from
36d35c7
to
8e8e6fa
Compare
ligustah
approved these changes
Apr 19, 2024
src/api.rs
Outdated
| Router::new() | ||
| .route("/health", get(health)) | ||
| .route("/list-all", get(list_all)) | ||
| .route("/submit-premint", post(submit_premint)) | ||
| .with_state(AppState { db, controller }) | ||
| .route("/submit-premintz", post(submit_premint)) |
There was a problem hiding this comment.
What's the intention here?
There was a problem hiding this comment.
I shall delete, was testing compilation of incremental route adding and missed removing 😅
| } | ||
|
|
||
| fn rule_name(&self) -> &'static str { | ||
| "collection address must start with 0xa" |
There was a problem hiding this comment.
I agree we should probably go for the trait constant approach. Will probably do that in a follow-up PR later, but it's probably better to make all the breaking changes now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify how we run start_services to pass in a rules engine, give an example of how to add custom routes and rules to mintpool (should be a stack off the prev pr)