Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a proper Evaluation type #13

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

ligustah
Copy link
Collaborator

@ligustah ligustah commented Apr 4, 2024

This helps distinguishing errors from rule violations. It also allows the caller to decide whether to accept a premint based on the specific results.

Copy link
Collaborator Author

ligustah commented Apr 4, 2024

@ligustah ligustah marked this pull request as ready for review April 4, 2024 20:48
@ligustah ligustah requested a review from erikreppel April 4, 2024 20:48
This helps distinguishing errors from rule violations. It also allows the caller to decide  whether to accept a premint based on the specific results.
Copy link
Collaborator Author

ligustah commented Apr 6, 2024

Merge activity

@ligustah ligustah merged commit 093fb30 into main Apr 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant