feature: support decompress and list archive file with password #646
Conversation
ttys3
changed the title
ttys3
force-pushed
the
ttys3
branch
3 times, most recently
from
443219b
to
1f33cca
Compare
ttys3
force-pushed
the
ttys3
branch
4 times, most recently
from
04edb66
to
3375d34
Compare
|
finally get tests issue on musl libc, aarch64, armv7 and macOS resolved. |
…s insta::assert_display_snapshot): use assert_snapshot!() instead
ttys3
changed the title
|
good news, After waiting for a rather long time, the upstream finally merged my PR. we can continue this PR now |
…and armv7-unknown-linux-gnueabihf
ttys3
changed the title
|
all checks are green now, cheers! I updated cross-rs image for
|
There was a problem hiding this comment.
Awesome PR! It covers a lot of things right and I appreciate the effort.
I updated cross-rs image for aarch64-unknown-linux-gnu and armv7-unknown-linux-gnueabihf because its gcc version is too old.
That's great!! I had no idea what was going on and this was blocking another PRs, that's a huge win, ty ty.
Although the PR is great, there is some rough edges to adjust.
I see you've done a hell lot for me in this one, so let me know if you want me to make the final adjustments for you 😉.
Refactor password handling in archive functions to use &[u8] instead of impl AsRef<[u8]>. Include better error reporting for invalid UTF-8 passwords in 7z archives.
Handle errors for unsupported formats in RAR and 7z archives by returning appropriate error messages.
Update error handling for unrar-specific issues to use the new UnrarError type.
Replace enclosed_name with mangled_name fallback for robustness.
Refactor list_archive functions to return results directly for better error handling.
Simplify password handling by removing platform-specific code and utilizing ByteSlice for all conversions.
Simplify the list_archive function by combining archive creation and listing steps. Remove the UnrarError variant from the Error enum as it's no longer used.
resolve #576
there's a bug in unrar.rs I submitted a PR muja/unrar.rs#49we need to wait upstream get merged so that we can have CJK filename support for rar files