Use informers #16
Open
Use informers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottoyiu
reviewed
Jul 4, 2019
| func (c *Controller) disableSrcDstCheck(key string) error { | ||
| defer c.workqueue.Done(key) | ||
|
|
||
| return retry.RetryOnConflict(retry.DefaultBackoff, func() error { |
There was a problem hiding this comment.
is it possible to have a less greedy retry that does not calling 'c.modifySrcDstCheckAttribute' again if there's a conflict?
| } | ||
|
|
||
| func (c *Controller) checkSrcDstAttributeEnabled(key string) (enabled bool, err error) { | ||
| defer c.workqueue.Done(key) |
There was a problem hiding this comment.
Having this method call 'c.workqueue.Done' is a bit hard to follow. Perhaps it can be placed before :
https://github.com/ottoyiu/k8s-ec2-srcdst/pull/16/files#diff-bff40c211a4e0c5aed5c55ab3cdbda41R10
and have the failure cases on 'processNextWorkItem' return early instead.
| if _, ok := node.Annotations[SrcDstCheckDisabledAnnotation]; ok { | ||
| srcDstCheckEnabled = false | ||
| func (c *Controller) disableSrcDstCheck(key string) error { | ||
| defer c.workqueue.Done(key) |
There was a problem hiding this comment.
likewise to my other comment regarding modifying the workqueue in this method.
|
hey @gjtempleton, I will work on merging this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #15.
This reimplements src-dst controller to use informers and workqueue. Will fix/add more tests and test on a cluster.