Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow some unused lints #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/builder/artifacts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async fn extract_archive(
buf.clear();
}

z.finish();
z.finish()?;

Ok(vec![chal.directory.join(archive_name)])
}
2 changes: 1 addition & 1 deletion src/builder/docker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ pub async fn copy_file(container: &ContainerInfo, from: PathBuf, to: PathBuf) ->

// extract single file from archive to disk
// we only copied out one file, so this tar should only have one file
if let Some(mut entry_r) = tar.entries()?.next() {
if let Some(entry_r) = tar.entries()?.next() {
let mut entry = entry_r?;
trace!("got entry: {:?}", entry.path());
let mut target = File::create(&to)?;
Expand Down
2 changes: 1 addition & 1 deletion src/cluster_setup/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ fn install_helm_chart(

// stream output to stdout
let reader = helm_cmd.reader()?;
let mut lines = BufReader::new(reader).lines();
let lines = BufReader::new(reader).lines();

for item in lines {
match item {
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![allow(unused)]
#![allow(unused_variables, unused_imports)]
// todo!: remove ^ later
// we dont need unused variables etc warnings while we're working on it

Expand Down