better Windows support

ostark · Jun 15, 2018 · 1af2801 · 1af2801
1 parent d053822
commit 1af2801
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.3] - 2018-06-15
+### Fixed
+- Better Windows support, thanks @ackwell
+
 ## [1.3.2] - 2018-04-06
 ### Fixed
 - Delegate Exception::getMessage() instead of Exception to error log

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
   "name": "ostark/craft-async-queue",
   "description": "A queue handler that moves queue execution to a non-blocking background process",
   "type": "craft-plugin",
-  "version": "1.3.2",
+  "version": "1.3.3",
   "keywords": [
     "craft",
     "cms",

diff --git a/src/QueueHandler.php b/src/QueueHandler.php
@@ -50,8 +50,10 @@ public function startBackgroundProcess()
      */
     protected function getCommand()
     {
-        $executableFinder = new PhpExecutableFinder();
-        if (false === $php = $executableFinder->find(false)) {
+        $finder = new PhpExecutableFinder();
+        $php    = $finder->find(false);
+
+        if (false === $php) {
             throw new \Exception('Unable to find php binary.');
         }
 
@@ -62,7 +64,9 @@ protected function getCommand()
 
 
     /**
-     * @param $path
+     * Quote path for windows or keep it as it is
+     *
+     * @param string $path
      *
      * @return string
      */