Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch : Fixed issue 14 and 18 #28

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Patch : Fixed issue 14 and 18 #28

wants to merge 7 commits into from

Conversation

Rits1272
Copy link
Member

@Rits1272 Rits1272 commented Jul 9, 2019

No description provided.

@akshatkarani
Copy link
Contributor

Don't change the name of the file.

akshatkarani
akshatkarani requested changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@akshatkarani akshatkarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work when I only provide author name and not the category, author and category need to optional arguments.

@Rits1272
Copy link
Member Author

Ok, I will change it.

@Rits1272
Patches
3551bee 
Updated the function so that if the category is not given then the function returns all the quotes of the person specified,
@Rits1272
Delete updated_brainyquote.py
08c1289
@Rits1272
Delete brainyquote.py
28e1e9c
@Rits1272
Patches
6a191f6 
Updated the function so that if the category is not specified then the function returns all the quotes of the input author.
@Rits1272
Fixing pep8 issues.
9728bf8
@akshatkarani
Copy link
Contributor

ping me when it's ready

@Rits1272
Copy link
Member Author

It's ready

akshatkarani
akshatkarani requested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@akshatkarani akshatkarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the author parameter should be optional, if I call get_quote() then also it should work.

@Rits1272
Copy link
Member Author

Rits1272 commented Jul 15, 2019 via email

@sunn-e sunn-e added the Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatkarani akshatkarani akshatkarani requested changes

Assignees
No one assigned
Labels
Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rits1272 @akshatkarani @sunn-e