53 render the notes searched on the searchbar #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st cases have been produced accordingly and pass
…render-notes-from-the-left-side-to-the-main-screen
…render-notes-from-the-left-side-to-the-main-screen
…nd not on the top navbar
…d be a good spot to fork
… was missing while initially implementing the test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the notes to render based on these search results. To do that I will update the NoteListView to accept a props of results and it will conditionally render the results if results is not null. I will also need to have the right hooks for state management.
I also need the search to be from just this one user because right now its searching all global notes, so thats a matter of chaning a few arguments.