52 render notes from the left side to the main screen #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st cases have been produced accordingly and pass
|
This issue is now ready for review and to be merged to main. The entire note object is now passed to the ToolPage which will now allow us to render any of the content on mobile on the web as it is all now there with types preserved. Test cases are also written ensuring that the required text is being rendered into the component when the note that is being passed in changes. This concludes the PR and resolves issue 52. |
…render-notes-from-the-left-side-to-the-main-screen
…render-notes-from-the-left-side-to-the-main-screen
yashb196
approved these changes
Dec 4, 2023
yashb196
deleted the
52-render-notes-from-the-left-side-to-the-main-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long PR for a long issue title.
This was not the easiest issue I have had, the text now renders on the main page. I had to pass note body text from the note_listview into the sidebar into the main page then from the main page pass it into the note component in order to render the text.
The proper parameter text was not available in the note and I found the type BodyText present. This is because the data conversion was not being made. I imported data conversion from the mobile app's codebase and made the necessary conversion.
This week I must add some test cases for this issue as well as pass along the entire note, instead of just the note's body text.