Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue 168 #169

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Fixes Issue 168 #169

merged 4 commits into from
Nov 4, 2024

Conversation

amychen108
Copy link
Collaborator

@amychen108 amychen108 commented Oct 24, 2024

Didn't get much done yet due to fall break last week.

1. PR Reference:
Fixes #168

2. What was changed:
Adjusted the UI design of the Intro.js onboarding tour popup. Modified the size and position of the Skip button and created test cases for the changes.

3. Why it was changed:
This change was necessary to improve the user experience during onboarding by enhancing the design of the Intro.js popup, making it easier to navigate and ensuring it aligns with the overall aesthetic of the website.

4. How it was changed:
For the frontend:
In globals.css: Updated the CSS to make the intro.js skip button smaller and reposition it slightly to the left for better alignment.
In page.tsx: imported globals.css so the new CSS can be used.
Added test case to ensure the UI adjustments work as expected.

Made sure it didn't break existing feature and that the feature still works as expected.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for animated-kangaroo-b914c6 failed.

Name Link
🔨 Latest commit e841a7f
🔍 Latest deploy log https://app.netlify.com/sites/animated-kangaroo-b914c6/deploys/672958812f659100089ef554

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for wheresreligion ready!

Name Link
🔨 Latest commit e841a7f
🔍 Latest deploy log https://app.netlify.com/sites/wheresreligion/deploys/67295881a6e4930008773ad5
😎 Deploy Preview https://deploy-preview-169--wheresreligion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jwang-101 jwang-101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw in ur PR that you know you need changes on the css side of the app aswell
looking forward to the new changes on the skip button to make it more visually pleasing

app/lib/pages/map/page.tsx Show resolved Hide resolved
Copy link
Collaborator

@BaloneyBoy97 BaloneyBoy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, all code meets requirement!

@BaloneyBoy97 BaloneyBoy97 merged commit c6bae64 into main Nov 4, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update on Frontend Introjs Tour Popup
4 participants