Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made a comment on what appears to be where changes are needed at first glance #73

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Made a comment on what appears to be where changes are needed at first glance #73

merged 4 commits into from
Sep 29, 2023

Conversation

irvinet20
Copy link
Collaborator

The goal of this issue is to change the text in notes so that media will be inline with the text as opposed to stacked at the top.

@yashb196 yashb196 marked this pull request as ready for review September 25, 2023 17:34
@yashb196 yashb196 self-requested a review September 25, 2023 17:34
@yashb196 yashb196 added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2023
@yashb196 yashb196 linked an issue Sep 25, 2023 that may be closed by this pull request
Audio Video Inline #68
Closed
yashb196
yashb196 reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@yashb196 yashb196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good and thank you for adding a test case we will need to fix the scroller before we push to main

yashb196
yashb196 requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@yashb196 yashb196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pull and push the recent changes we will push this to main as it is i just need the updated version

yashb196
yashb196 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@yashb196 yashb196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is in order pushing to main

@yashb196 yashb196 merged commit d466d97 into main Sep 29, 2023
1 check passed
@yashb196 yashb196 deleted the InlineMediaIssue branch June 15, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashb196 yashb196 yashb196 approved these changes

Assignees

@irvinet20 irvinet20

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
LRDA_Mobile
Status: Dev-Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio Video Inline
2 participants
@irvinet20 @yashb196