Allow Users to select Photo from Camera Roll to Field Notes #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashb196
added
enhancement
AndchooChen
changed the title
yashb196
requested changes
Sep 22, 2023
|
Approving the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys! Hope you are doing well! This pull request attempts to fix the issue 69 (OH YEAH).
As of now, when the user is creating a field note, the user is not able to add a photo from their gallery to insert into their field note. It only gives access to the user so that he or she can add a photo that is directly taken from the camera at that moment. The goal of this pull request is to give access to the user so that they can finally add photos from their camera roll.
Previously, users press on the photoScroller icon, it directs them to their camera app to snap a photo. With this PR, the icon will now ask the user if they want to instead choose from camera roll with an Alert. See screenshot below:
In the previous version of the app, this alert would not pop up and would send users directly to their camera. Furthermore, in the AddNoteScreen.test, a test was created to check if the alert pops up correctly.