Fix: Issue #98 #166
Fix: Issue #98 #166
Conversation
lib/screens/mapPage/ExploreScreen.js
Outdated
| @@ -649,12 +649,12 @@ const styles = StyleSheet.create({ | |||
| position: "absolute", | |||
| marginTop: Constants.statusBarHeight, | |||
| flexDirection: "row", | |||
| backgroundColor: "#fff", | |||
| backgroundColor: theme.primaryColor, | |||
There was a problem hiding this comment.
Nice job making it a variable
lib/screens/mapPage/ExploreScreen.js
Outdated
| width: "90%", | ||
| alignSelf: "center", | ||
| borderRadius: 5, | ||
| padding: 10, | ||
| shadowColor: "#ccc", | ||
| shadowColor: theme.text, |
There was a problem hiding this comment.
nice work switching from a hard coded value to a variable
| @@ -716,6 +716,7 @@ const styles = StyleSheet.create({ | |||
| textContent: { | |||
| flex: 2, | |||
| padding: 10, | |||
| color: theme.text, | |||
| }, | |||
| cardtitle: { | |||
| fontSize: 12, | |||
There was a problem hiding this comment.
This is a lot of lines for a file, do we need it to be this long?
There was a problem hiding this comment.
Maybe look to divi up some of these components into more files
AmarHadzic
requested review from
AmarHadzic and
rcAsironman
and removed request for
AmarHadzic
lib/components/tagging.tsx
Outdated
There was a problem hiding this comment.
What is the purpose of these changes? Looks like rearranging of imports.
| import { formatToLocalDateString } from "../../components/time"; | ||
| import ApiService from "../../utils/api_calls"; | ||
| import NoteDetailModal from "./NoteDetailModal"; | ||
| import { mapDarkStyle, mapStandardStyle } from "./mapData"; |
There was a problem hiding this comment.
These changes look like rearrangement of imports, is there a purpose behind this?
|
Hello @teamomiamigo, I appreciate your efforts, but I’m encountering issues with the code. I’m unable to simulate the app, and it throws a "theme doesn't exist" error. Additionally, when raising a PR, please include a comment in the PR description indicating the issue it resolves. For example, if the PR addresses issue #160, the first comment in the PR should be: "Fixes #160." Thank you for your attention to these matters.
|
|
I have made new commits and changes to fix the colors so that the search bar text is in the black text and is set to the white text during dark mode now. due to simulator issues, I wasn't able to see this issue in this. |
What needs to be changed:
Changing the text in the search bar of the map to be white during dark mode and not be black
Why is changed:
The text is unreadable during dark mode as the text is in black, where it should be white and be applied with the theme color.
How it is changed:
Whether in dark mode in light mode, I have ensured that the text color represents the dark or light theme