-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 161 search published entries #165
Conversation
This PR shows some of the same changes as PR #164. Does anyone understand why this is happening? @yashb196 @rcAsironman |
i believe it might be a local pull from the branch that may have shown the same changes as 164 |
@kate-holdener, I believe this is because we branched out of the home-screen-nav branch and not main, but we have that mess solved we are going to branch out of main and re apply our feature to the main branch. Thank You |
@ademDurakovic Search Scope Adjustment |
…-slu/lrda_mobile into 161-search-published-entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Lots of important changes that are put into the search bar for finding things better and looking for more detailed to find published entries based on the search bar text inputted.
expect(getByTestId('searchBar')).toBeTruthy(); | ||
}); | ||
|
||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how you are able to search through published entries, whether it is before or after each and that you are looking for certain things.
color: theme.text, | ||
borderWidth: 3, | ||
|
||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the colors to show importance of keeping the search bar intact when it comes to styling.
return ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the idea behind searching for entries in the search bar is better now, as you looking for more details and information when text is inputting into the search bar.
Fixes #161
Search bar added to the published entries and my entries so that users can search by date or title of notes.
This is needed because it make the user experience much better especially when the total notes grows.
I added a TextInput in the HTML part of the HomeScreen file and the render notes function was changed so that it filtered only the ones based on what is in the search bar. The total notes counter also needed to be updated so there is a variable for that in the code.