Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 161 search published entries #165

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Conversation

ademDurakovic
Copy link
Collaborator

@ademDurakovic ademDurakovic commented Sep 15, 2024

Fixes #161
Search bar added to the published entries and my entries so that users can search by date or title of notes.

This is needed because it make the user experience much better especially when the total notes grows.

I added a TextInput in the HTML part of the HomeScreen file and the render notes function was changed so that it filtered only the ones based on what is in the search bar. The total notes counter also needed to be updated so there is a variable for that in the code.

@ademDurakovic ademDurakovic changed the title 161 search published entries Fixes 161 search published entries Sep 16, 2024
@kate-holdener
Copy link

This PR shows some of the same changes as PR #164. Does anyone understand why this is happening? @yashb196 @rcAsironman

@yashb196 yashb196 added the enhancement New feature or request label Sep 18, 2024
@yashb196
Copy link
Collaborator

This PR shows some of the same changes as PR #164. Does anyone understand why this is happening? @yashb196 @rcAsironman

i believe it might be a local pull from the branch that may have shown the same changes as 164

@ademDurakovic
Copy link
Collaborator Author

This PR shows some of the same changes as PR #164. Does anyone understand why this is happening? @yashb196 @rcAsironman

@kate-holdener, I believe this is because we branched out of the home-screen-nav branch and not main, but we have that mess solved we are going to branch out of main and re apply our feature to the main branch.

Thank You

@rcAsironman
Copy link
Collaborator

@ademDurakovic
Fantastic work on implementing the search functionality! Your code is well-structured and demonstrates a strong grasp of the requirements. I have one key suggestion to ensure everything aligns perfectly with the project goals:

Search Scope Adjustment
The current implementation searches across all entries. However, the requirement specifies that the search should focus solely on published entries. Please adjust the filtering logic to ensure that only published notes are included in the search results.
Your attention to this detail will enhance the functionality and ensure it meets the project specifications. Keep up the great work—your contributions are highly valued!

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@rcAsironman rcAsironman merged commit 4d60f39 into main Sep 24, 2024
2 checks passed
Copy link
Collaborator

@teamomiamigo teamomiamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Lots of important changes that are put into the search bar for finding things better and looking for more detailed to find published entries based on the search bar text inputted.

expect(getByTestId('searchBar')).toBeTruthy();
});

});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how you are able to search through published entries, whether it is before or after each and that you are looking for certain things.

color: theme.text,
borderWidth: 3,

},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the colors to show importance of keeping the search bar intact when it comes to styling.

return (

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the idea behind searching for entries in the search bar is better now, as you looking for more details and information when text is inputting into the search bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Dev-Done
Development

Successfully merging this pull request may close these issues.

Implement search functionality on the published entries page.
5 participants