Map starting location #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 18, 2024 20:42
Closed
yashb196
reviewed
Apr 22, 2024
|
Hello! The unknown changes are just fixing some of the indentations and white space between lines of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
What was changed?
For this pull request, the files that were changed were the ExploreScreen and I also added a ExploreLoadingScreen
Why was it changed?
One thing we were requested to add for this issue was to add loading the ExploreScreen based on the location of the User. This is because by default the ExploreScreen started at St. Louis. Now because it starts based on the location of the user, it will be more relevant to the user when they first open up the screen. However, one thing that should be changed because of this is that cards should be based on proximity of the user.
How was it changed?
So a useEffect was used to grab the user's location and then the latitude and longitude were changed to match the user's location. Additionally, an ExploreLoadingScreen was added so now the LoadingScreen shows first on initial render to allow for the useEffect to grab location first!
Screenshots that show the changes (if applicable):