Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding change #129

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Onboarding change #129

merged 9 commits into from
Mar 18, 2024

Conversation

yashb196
Copy link
Collaborator

What was changed?

Onboarding screen animations

Why was it changed?

Hello Everyone, Hope you are enjoying your spring break. I have been trying to improve the Onboarding Screens to make them seem more professional. Hence here is how the screens look now

How was it changed?

*Used mp4 files which were mentioned by Dr.Park which align with the where's religion theme and replaced lottefiles *

Screenshots that show the changes (if applicable):
Old Onboarding Screen

Screenshot 2024-03-14 at 3 26 58 PM Screenshot 2024-03-14 at 3 27 09 PM Screenshot 2024-03-14 at 3 27 20 PM

New Onboarding Screens

Screenshot 2024-03-14 at 1 51 26 PM Screenshot 2024-03-14 at 3 27 41 PM Screenshot 2024-03-14 at 3 27 48 PM Screenshot 2024-03-14 at 3 19 22 PM Screenshot 2024-03-14 at 3 18 44 PM

@yashb196 yashb196 added enhancement New feature or request good first issue Good for newcomers labels Mar 14, 2024
@yashb196 yashb196 self-assigned this Mar 14, 2024
Copy link
Collaborator

@irvinet20 irvinet20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new look and animations on it!

@yashb196 yashb196 merged commit 56387e7 into main Mar 18, 2024
2 checks passed
@Stuartwastaken
Copy link
Collaborator

Hey @yashb196 cool to update, but you should know a few points of feedback:
The margins aren't standard on the left and right, some of these are centered, some not.
There is a lot of text so its hard for people to care about reading that much
Its really large font, and the font is not standard. You should have 2-3 font families used through the entire app. Call from those variables
Some of the .mp4's are clipped

@yashb196 yashb196 deleted the onboarding_change branch June 15, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Dev-Done
Development

Successfully merging this pull request may close these issues.

4 participants