Adding Video Inline to Notes, Adjusting the size of images and videos, and Editor in Darkmode #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2024 23:12
AndchooChen
added
bug
added 8 commits
February 28, 2024 16:44
…and EditNoteScreen
…r both the AddNoteScreen and EditNoteScreen
…y videos are only showing the thumbnail and not being able to play any video
…ntly have it so that videos have a thumbnail and that they can be played from the add and edit note screens
…o the note detail modal, the uri shows up for now
… custom renderers for the note modal screen
yashb196
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all!
This issue fixes: #126
** What was changed? **
This pull request attempts to fix the issues found in issue #126. In particular, it will bring changes to allow Videos to be placed inline for both AddNoteScreen and EditNoteScreen, fix the issue of the RichTextEditor in Darkmode, and allow for images to properly be sized in Note Views. Currently, there are no fixes for added videos to the NoteDetailModal.
** Why was it changed? **
These changes felt necessary because improving the experience of the story that Ethnographers and people alike are trying to tell is important. Having videos that are inline for people to view in the certain spot of the note helps facilitate the story. Moreover, it's important to make the NoteViews of these creates nice.
** How was it changed? **
Going more specifically into it, there is now a custom renderer that adjusts![]()
tag that are found when the html is being rendered. Additionally, the same flow was used to add video inline in the same way that made it possible to add images to the note screens. Styles were also changed to change the color of the editor!
A test case was also added!
Files that were specifically modified: AddNoteScreen.tsx, EditNoteScreen.tsx, photoScroller.tsx, NoteDetailModal.tsx
Screenshots that show the changes (if applicable):
