Fixing Note Visual Bug #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashb196
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you guys had a very good break and spent time with loved ones, whether it be through the phone or in person! Anyways, this issue attempts to fix the bug in which the note on both the AddNoteScreen and the EditNoteScreen is only being displayer for half of its possible screen real estate. Here is what the current layout of those two screens look like right now:
Before (The issue comes from when there is no keyboard. There is more to the note below, but the scroll does not allow you to see it) :
After:
So now after these changes, the cursor will go below the picture after a picture is added inline and also, the full screen will show what is available in the RichEditor and not cut off as it did before.