eliminated fetchprojectData in the webcomponent and now uses the fetc… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-fidahussain-SLU
requested a review
from MutyaSowmya123
as a code owner
Matthew-Clendenning
requested changes
Nov 11, 2024
Yes, check for the functionality that is being repeated and delete one of the file. Implementing (if required ) some things from one of the files. |
MutyaSowmya123
requested changes
Nov 12, 2024
|
I have deleted the other fetchProjectData file as that had outdated and hard-coded tokens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
What was changed: There was a separate fetchData function and a fetchData function built in the web-component. To maintain code reusability I eliminated the fetchData function that was built in the web-component and used the existing fetchData function that was separate.
Why was it changed: This was to eliminate code duplicates and reduce confusion on which one to use.
How was it changed: