Bug/lint fixes #45
Merged
Bug/lint fixes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 24, 2024 17:57
Nissa9902
approved these changes
Oct 28, 2024
| assert websocket.close |
There was a problem hiding this comment.
The bug and lint fixes were well-executed and have enhanced overall clarity. Nice job keeping things clean and efficient, Jack!
git-voo
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
This is Good work!
Let's get this in. Once this gets in, @colinseper @Nissa9902 will have to update their branches from main to ensure this pipeline runs successfully on their pushes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed:
Why was the change needed:
How was it changed: