-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target zone estimation functionality and step time tests #37
Conversation
Removed unnecessary Zone.Identifier files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, but overall looks good for the code you have. Just need to implement the frontend connection.
accidental file
Added a new section to display target zones (Left Foot, Right Foot, and Average Target Zone) in the Step Time interface.
Implemented WebSocket connection to receive real-time step times and target zones from the backend. Updated the state in "useStepTime" hook to reflect live data by parsing the incoming WebSocket message and updating step times and target zones accordingly. Added cleanup functionality to close the WebSocket connection when the component unmounts.
Added the handle_threshold() function to make the threshold more modular, allowing flexibility in setting it during the function call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything I asked for looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Nissa, I made a few changes to fix linter errors, batch process forcedata and invoke the streaming function from main.
fixes issue #33
What Was Changed:
Why It Was Changed:
This change was essential for providing real-time feedback to users during step time calculations, enabling them to visualize target zones and step times dynamically.
How It Was Changed: