Adding Pipeline to Repo #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new branch where I am going through GitHub actions to create the pipeline
Nissa9902
reviewed
Oct 14, 2024
| @@ -34,7 +34,7 @@ function App() { | |||
|
|
|||
| websocket.current.onclose = (event) => { | |||
| console.log("WebSocket connection closed: ", event); | |||
| websocketConnected = false; | |||
| // websocketConnected = false; | |||
| }; | |||
|
|
|||
| return () => { | |||
There was a problem hiding this comment.
Proper state management for WebSocket connection in frontend.
Nissa9902
approved these changes
Oct 14, 2024
| isort==5.13.2 | ||
| pylint==3.3.1 | ||
| tomlkit==0.13.2 |
There was a problem hiding this comment.
Good job setting up the CI workflow for both building and linting! The matrix and Python setup is clear and structured well.
Nissa9902
approved these changes
Oct 14, 2024
| source env/bin/activate | ||
| cd ${{github.workspace}}/backend | ||
| pytest -s websocketUnitTest.py | ||
|
|
There was a problem hiding this comment.
Great test for WebSocket! Check edge cases too
git-voo
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Why was the change needed:
How was it changed: