Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #75 - Unresolved Directive #86

Closed

Conversation

SwindleA
Copy link
Collaborator

Unable to actually see if this fix works until it is merged into develop. Locally it builds the same as before, correctly. Will probably need to merge, and revert the changes should it not work.

The main change is in the gradle build file, micronautpi4j-utils/build.gradle. I changed the asciidoctor base directory to be the same for each individual source file. Because the issue is with the include paths, my best guess is to change the base directory. The configuration methods can be found in the Asciidoctor Gradle plugin Docs The asciidoctor docs also talks about how include paths are tricky.

Should this fix not work, my other option is to include the files through a url to github. Asciidoctor has this method not enabled by default because of security reasons. Because the link is to our own code, there should be no issues. Asciidoctor include content by URI

@SwindleA SwindleA self-assigned this Oct 14, 2023
@SwindleA SwindleA linked an issue Oct 14, 2023 that may be closed by this pull request
@SwindleA SwindleA marked this pull request as ready for review October 18, 2023 20:30
@SwindleA SwindleA changed the base branch from develop to main October 18, 2023 20:31
jyanev and others added 2 commits October 18, 2023 15:33
* allow setting led color via hex value

* set controller endpoint for setting RGB via hex

* fixed spacing error in url for hex converter with frequencies

---------

Co-authored-by: Adrian Swindle <[email protected]>
@SwindleA SwindleA changed the base branch from main to develop October 18, 2023 20:33
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ SwindleA
✅ jyanev
❌ GreihMurray
You have signed the CLA already but the status is still pending? Let us recheck it.

@SwindleA SwindleA closed this Oct 18, 2023
@SwindleA SwindleA deleted the 75-fix-unresolved-directive-documentation-bug branch October 18, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "unresolved directive" Documentation Bug
4 participants