41 seven segement display documentation #284
Conversation
| * 1 x Seven Segment Display | ||
| * Jumper wires | ||
| * Breadboard | ||
| * Power source |
There was a problem hiding this comment.
Some of the other documentation files mention the amount of power needed by the power source. It could be helpful to add it here.
| ===== Circuit Setup | ||
|
|
||
| 1. Place the Seven Segment Display on the breadboard. | ||
| 2. Connect each segment of the display to its respective GPIO pin as specified in the YAML configuration. |
There was a problem hiding this comment.
Maybe this should be more detailed and describe where the wiring should go.
|
|
||
| ===== Circuit Diagram | ||
|
|
||
| image::/Users/jeongseyun7/Desktop/Capston1/Sprint4/Refreshed/Pi4Micronaut/Circuit_Diagram.png[] |
There was a problem hiding this comment.
This should be a relative file path, not a local one. This won't show up on any computer but yours!
Instead, this line should look like:
image::Circuit_Diagram.png[]
The image should be placed inside pi4micronaut-utils/src/docs/asciidoc/img. It looks like the images aren't added and committed yet, so be sure to do that as well.
| 1. Place the Seven Segment Display on the breadboard. | ||
| 2. Connect each segment of the display to its respective GPIO pin as specified in the YAML configuration. | ||
| 3. Use a common ground to connect the display to the Raspberry Pi. | ||
| 4. Refer to the circuit diagram for detailed wiring instructions. |
There was a problem hiding this comment.
I do like this reminder to refer to the circuit diagram!
|
|
||
| [source, java] | ||
| ---- | ||
| package com.opensourcewithslu.components.controllers; |
There was a problem hiding this comment.
The code here should be linked to the SevenSegmentController.java file instead of being hardcoded and rewritten here.
There was a problem hiding this comment.
Your pull request includes helper functionality, controller, and YAML configuration changes that were already pushed in the previous sprint. Since that pull request is still pending, you should push updates into the existing one instead. This current pull request should only contain files modified under the docs section. Please remove all unrelated files to keep the changes focused and maintain a clean commit history
Overview: Introduction to the Seven Segment Display component and its purpose.
Components: List of required hardware components.
Circuit Setup: Step-by-step guide for setting up the display on a breadboard.
Circuit and Schematic Diagrams: Visual references for wiring.
YAML Configuration: Detailed YAML setup for integrating the display with Raspberry Pi via I2C.
Functionality and Testing: Instructions for displaying numbers and controlling segments.
Troubleshooting: Common issues and solutions.