Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Branch created to solve CLA Issue #254

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

ThomasMacas
Copy link
Collaborator

Fixes #246

Created error handling blocks for each controller that uses LED status indication. This was changed because for the issue to be resolved the controllers that use LED status indication needed to have informational error handling. Try catch blocks were added to areas of where the controllers used LED status indication in the form of LEDHelper(ledon, ledoff). Informational error messages were added for ease of error handling as well as logging capability.

Closing old pull request "Fixes 246" due to CLA issues. Needed to create new branch and pull request to solve CLA issue that was occurring due to unregistered commits.

@yrlmanoharreddy yrlmanoharreddy mentioned this pull request Sep 22, 2024
Copy link
Collaborator

@yrlmanoharreddy yrlmanoharreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great and #246 is resolved

@yrlmanoharreddy yrlmanoharreddy merged commit bb8ddd0 into main Sep 22, 2024
6 checks passed
@yrlmanoharreddy yrlmanoharreddy deleted the 246-LEDStateErrorHandling branch September 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Error Handling for LED State Switch in All Component Controllers
2 participants