Create unit improved #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto CreateUnitImproved
Comment on lines
+36
to
+37
| defaultMeterMinimumValue:Number.MIN_SAFE_INTEGER, | ||
| defaultMeterMaximumValue:Number.MAX_SAFE_INTEGER, |
There was a problem hiding this comment.
Please use
import { MAX_VAL, MIN_VAL } from '../../redux/selectors/adminSelectors';
Both refer to the same value but the above import is used in places where ever the requirement is for max and min values. So please use the above import to mantain uniformity in the code
| <Row xs='1' lg='2'> | ||
| {/* default Meter Minimum Value input */} | ||
| <Col><FormGroup> | ||
| <Label for='defaultMeterMinimumValue'>{translate('default.meter.minimum.value')}</Label> |
There was a problem hiding this comment.
Coordinate with @lawsj on the translations
Comment on lines
+85
to
+86
| defaultMeterMinimumValue: 0, | ||
| defaultMeterMaximumValue: 0, |
There was a problem hiding this comment.
For no unit, the values should be -Infinity,Infinity. Please refer to the meeting recording for any clarification
Comment on lines
+16
to
+17
| default_meter_minimum_value INTEGER NOT NULL, | ||
| default_meter_maximum_value INTEGER NOT NULL, |
There was a problem hiding this comment.
As discussed the new columns must be added via ALTER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I gone further into implementing the CreateUnit Functionality. Ive added more connection to the backend aswell has fix some impletation issues
Fixes #[issue]
(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
currently giving errors due when creating units