Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backend Support for HTML File Links #167

Open
3 tasks
mohamdlog opened this issue Nov 3, 2024 · 0 comments · May be fixed by #171
Open
3 tasks

Add Backend Support for HTML File Links #167

mohamdlog opened this issue Nov 3, 2024 · 0 comments · May be fixed by #171
Assignees
Milestone

Comments

@mohamdlog
Copy link
Member

Description:
Update the Flask server to include HTML files from the GCS bucket in the /list-folder-contents/<folder_name> endpoint response. The backend should recognize HTML files, generate public URLs for them, and include these in the response JSON.

Acceptance Criteria:

  • Modify the process_gcs_directory function to detect HTML files and add them to the response.
  • Ensure the response JSON includes a path attribute for HTML files containing the public URL.
  • Make sure HTML files are categorized properly within the relevant monitor lists in the JSON response.

Reason:
Building out the backend first ensures the data is readily available and well-structured for the frontend. This approach helps reduce integration issues later and allows for easier testing and validation of the new functionality.

How to Test:

  • Run the Flask server.
  • Use Postman to send a POST request to http://localhost:5000/list-folder-contents/<folder_name>.
  • Check the JSON response for HTML file details with a valid path.
  • Test URLs by opening them in a browser to confirm accessibility.

Good Files to Look at for More Information:

  • Our bucket contains batches that have HTML files. One example is 2024-10-21-11-27-28_Batch_2/.
  • DroneWorld\backend\PythonClient\server\simulation_server.py.
@mohamdlog mohamdlog added this to the Sprint 5 milestone Nov 3, 2024
@Hoshi-Okami Hoshi-Okami self-assigned this Nov 11, 2024
@Hoshi-Okami Hoshi-Okami linked a pull request Nov 11, 2024 that will close this issue
@Hoshi-Okami Hoshi-Okami linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants