fix(vcs): Consider VCS configurations in cache lookup #9800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9800 +/- ##
=========================================
Coverage 68.07% 68.07%
Complexity 1285 1285
=========================================
Files 249 249
Lines 8828 8828
Branches 918 918
=========================================
Hits 6010 6010
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
Jan 22, 2025
When looking up a VCS implementation by repository URL or by a working tree directory from the cache, also consider the requested VCS configurations. Fixes oss-review-toolkit#9795. Signed-off-by: Wolfgang Klenk <[email protected]>
wkl3nk
force-pushed
the
wkl3nk/consider-vcs-configurations-in-cache-lookup
branch
from
485d5de to
584c41a
Compare
sschuberth
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up a VCS implementation by repository URL or by a working tree directory from the cache, also consider the requested VCS configurations.
Fixes #9795.