Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi path process #2758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

multi path process #2758

wants to merge 2 commits into from

Conversation

chaoliang-wei
Copy link

multi path process

@imcom
Copy link
Contributor

imcom commented Sep 18, 2024

could you describe why would there be the addSet and delSet for multi-path? What's the intended use case?
cc @fujita

@imcom
Copy link
Contributor

imcom commented Jan 2, 2025

Hi @fujita seeking your advice here. This PR seems to have breaking changes. However, I do like to know what's the best way to handle the Multi Path watch / chagnes
Thanks in advance

@fujita
Copy link
Member

fujita commented Jan 2, 2025

There are some pull requests that break the APIs. We can merge them with the major version bumped.
I need the detailed description on this, not just "multi path process".

@imcom
Copy link
Contributor

imcom commented Jan 2, 2025

Hi @fujita I found an issue related to this PR. I assume this PR is trying to address the discussion here #2746
Would you please take another look so we can get this PR moving forward
Discussion is more than welcome. We would like to settle on the implementation and use case

@fujita
Copy link
Member

fujita commented Jan 10, 2025

This breaks the public API (watch API), right? So we need to update the major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants