Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuda snippet according to nvidia official instructions #299

Merged
merged 6 commits into from
Nov 10, 2024
Merged

Update cuda snippet according to nvidia official instructions #299

merged 6 commits into from
Nov 10, 2024

Conversation

jonazpiazu
Copy link
Contributor

Fixes #298

@jonazpiazu jonazpiazu marked this pull request as ready for review November 7, 2024 15:47
@jonazpiazu jonazpiazu requested a review from tfoote as a code owner November 7, 2024 15:47
tfoote
tfoote approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this and providing a PR. I did a bit more updating for the new supported versions. If you have a chance to test it that would be great. I'm not going to wait for a test to merge since it's broken for all CUDA users right now.

@tfoote tfoote merged commit 24dd5e1 into osrf:main Nov 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken packages when using the cuda extension
2 participants
@jonazpiazu @tfoote