Just resetUpdate Mempool on propose #114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just call resetUpdate right before we reap. The only risk is in a case where the proposer has rechecked like 10 txs (since its super slow), but you reap like 100 txs. But all that happens then is you as the proposer just propose some txs that may fail recheck. (Which may already happen)
If thats really a problem, thats now the app's problem :)
PR checklist
.changelog
(we use unclog to manage our changelog)docs/
orspec/
) and code comments