Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PL Bank BPS #10399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update PL Bank BPS #10399

wants to merge 1 commit into from

Conversation

praszuk
Copy link

@praszuk praszuk commented Jan 26, 2025

Remove name from Bank BPS.

Bank BPS is more likely a parent organization that unites local banks.
Each local bank in the BPS group has its own name, typically formatted as "Bank Spółdzielczy in [area]", and manages its own branches in the surrounding areas.

The main bank, currently named Bank BPS, operates only 12 branches. In contrast, there are over 300 local banks with more than 2,300 branches.

@Snowysauce Snowysauce added the fix data Need to cleanup the data in OSM after this is released label Jan 27, 2025
@Snowysauce
Copy link
Collaborator

Since there are banks with the name "Bank BPS", the best approach is probably to leave the name preset as is, but add preserveTags to allow editors to override the default name suggestion.

@Snowysauce
Copy link
Collaborator

After reading the second link, I'm not sure if this preset should continue to be used in its current fashion. As you mentioned, the main bank of the network is Bank BPS, and its branches carry the brand of the same name . But, as you also mentioned, the network also includes over 300 other banks, which I presume have their own set of names and what the NSI would consider a brand name. Even if we consider the network as one unit, from what I understand, the correct brand name for it would be "Banki Spółdzielcze z Grupy BPS" and should be treated as a distinct entry from the main bank.

@praszuk
Copy link
Author

praszuk commented Jan 27, 2025

@Snowysauce Thank you for the detailed response and for analyzing the sources!

After reading the second link, I'm not sure if this preset should continue to be used in its current fashion

That’s exactly why I want to change it!

Even if we consider the network as one unit, from what I understand, the correct brand name for it would be "Banki Spółdzielcze z Grupy BPS" and should be treated as a distinct entry from the main bank.

I am currently looking for advice on what would be better option here.
I've noticed that we already have many entries for local banks. However, maintaining over 300 brands would require too much effort and could also be problematic for mappers and data consumers.

Some of these already exist on the wikidata, so I don’t think it would be an issue, and I also don’t see any reason to remove them.
I’m leaning more toward the network approach, as you mentioned. This wouldn’t conflict with the local brands.

What do you think about network along with network:wikidata? Could we define something like this in the NSI project?

    {
      "displayName": "Banki spółdzielcze Grupa BPS",
      "id": "bankbps-68054b",
      "locationSet": {"include": ["pl"]},
      "matchNames": ["Bank BPS", "spółdzielczy"],
      "tags": {
        "amenity": "bank",
	"network": "Grupa BPS",
	"network:wikidata": "Q86673022"
      }
    },

https://www.wikidata.org/wiki/Q86673022

Then mappers could add local name and brand according to the Wikidata.

@Snowysauce Snowysauce added the question Not Actionable - just a question about something label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released needs research question Not Actionable - just a question about something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants