Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加 #10323 提到的機構 #10388

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

添加 #10323 提到的機構 #10388

wants to merge 4 commits into from

Conversation

iigmir
Copy link
Contributor

@iigmir iigmir commented Jan 23, 2025

Add the following brands that have existed on Wikidata or OSM:

中文 English Wikidata Type
明光義塾 Meikō Gijuku Q11512003 amenity=prep_school
佳音英語 Joy English Q10887049 amenity=prep_school, amenity=language_school, office=educational_institution
Qburger Qburger Q131858964 amenity=fast_food
千葉火鍋 Chien Yen Shabu Shabu Q67936077 amenity=fast_food
千葉火鍋 Chien Yen Shabu Shabu Q67936077 amenity=fast_food
石二鍋 Shi Erguo Q108056247 amenity=restaurant
21世紀風味館 21Plus Q28416350 amenity=fast_food
胖老爹 Fat Daddy American Fried Chicken Q66768745 amenity=fast_food
中國青年救國團 China Youth Corps Q700615 amenity=community_centre

In addition, I have created Chinese, Japanese, and Korean aliases (matchNames in the NSI sense) for Wacoal, Triumph, and Chunghwa Telecom because not everyone knows their official name (for example, Wacoal is known as "華歌爾" rather than Wacoal for many Taiwanese people). The aliases don't change their brand or name prop since I just add matchNames.

@Snowysauce Snowysauce added add brand Actionable - add a brand to the index fix data Need to cleanup the data in OSM after this is released labels Jan 23, 2025
@LaoshuBaby LaoshuBaby marked this pull request as draft January 24, 2025 11:26
@iigmir
Copy link
Contributor Author

iigmir commented Jan 27, 2025

@LaoshuBaby 我想確定一下,在重新發布推送請求前,需要先確定什麼事情。
I want to make sure what steps I should take before requesting again.

@LaoshuBaby
Copy link
Collaborator

@LaoshuBaby 我想確定一下,在重新發布推送請求前,需要先確定什麼事情。 I want to make sure what steps I should take before requesting again.

尽量先把需要的品牌加上争取合在一个PR里面?因为 #10323 提到的确实真的不少,我看您只列出来了几个,想可能会是一个需要持续编辑的PR,所以给设draft了……🥹

Try to add the brands you need and combine them into one PR first? Because there are indeed quite a few mentioned in #10323, and I see you only listed a few. It seems like this could be a PR that requires continuous editing, so I've set it as a draft... 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index fix data Need to cleanup the data in OSM after this is released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants