fix: fix fav icon path

oslabs-beta · Aug 22, 2024 · 19636b7 · 19636b7
1 parent e430fd0
commit 19636b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.github/workflows/aws.yml b/.github/workflows/aws.yml
@@ -61,7 +61,7 @@ jobs:
           set -e
           set -o pipefail
 
-          # Update the ECS service to use the latest task definition revision and capture output
+          # Update the ECS service and capture output
           UPDATE_OUTPUT=$(aws ecs update-service \
             --cluster ${{ env.ECS_CLUSTER }} \
             --service ${{ env.ECS_SERVICE }} \

diff --git a/client/public/index.html b/client/public/index.html
@@ -1,16 +1,23 @@
-</html>
 <!DOCTYPE html>
 <html lang="en">
 
 <head>
   <meta charset="UTF-8">
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>SkyScraper</title>
+
+  <!-- Ionicons for icons -->
   <script type="module" src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.esm.js"></script>
   <script nomodule src="https://unpkg.com/[email protected]/dist/ionicons/ionicons.js"></script>
-  <link rel="icon" type="image/x-icon" href="client/public/favicon.ico">
+
+  <!-- Favicon -->
+  <link rel="icon" href="/favicon.ico" />
+
+  <!-- Preconnect for Google Fonts -->
   <link rel="preconnect" href="https://fonts.googleapis.com">
   <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
+
+  <!-- Google Fonts -->
   <link href="https://fonts.googleapis.com/css2?family=Overpass+Mono:[email protected]&display=swap" rel="stylesheet">
 </head>