Bump module versions #300
Merged
Bump module versions #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request involves multiple updates across various Terraform configuration files, primarily focusing on version upgrades for Terraform providers (Google, Helm, Kubernetes) and several Kubernetes-related modules. The changes span multiple directories, including cert-manager, datadog, istio, onboarding, and opa-gatekeeper. The updates include incrementing provider versions from 6.12.0 to 6.14.1 for Google, 2.16.1 to 2.17.0 for Helm, and 2.34.0 to 2.35.1 for Kubernetes, along with corresponding hash value updates in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
💰 Infracost reportMonthly estimate generatedEstimate details (includes details of unsupported resources and skipped projects due to errors) |
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east4-a
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east1-b
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
brettcurtis
temporarily deployed
to
Sandbox: Main
GitHub Actions
Inactive
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
shared/tfvars/sandbox.tfvars(1 hunks)
🔇 Additional comments (1)
shared/tfvars/sandbox.tfvars (1)
2-4: Verify the GCP service account exists
The configuration references a service account plt-backstage-github@ptl-lz-terraform-tf91-sb.iam.gserviceaccount.com. Ensure this service account exists in GCP before applying these changes.
Let's verify the service account pattern consistency across the codebase:
shared/tfvars/sandbox.tfvars
Outdated
Comment on lines
2
to
4
| backstage = { | ||
| google_service_account = "plt-backstage-github@ptl-lz-terraform-tf91-sb.iam.gserviceaccount.com" | ||
| } |
There was a problem hiding this comment.
💡 Codebase verification
Istio injection should be enabled for the backstage namespace
Based on the evidence found in the codebase:
- The
variables.tffile shows thatistio_injectionis a supported configuration option with a default value of "disabled" - The
gke-infonamespace hasistio_injectionexplicitly set to "enabled" - The presence of extensive Istio gateway DNS configurations and virtual services across the codebase indicates that Istio is actively used in the cluster infrastructure
Since Istio is clearly a core part of the infrastructure (evidenced by the numerous Istio gateway and virtual service configurations), the backstage namespace should have Istio injection enabled for consistency with other service namespaces like gke-info.
🔗 Analysis chain
Consider if istio_injection setting is needed
The gke-info namespace has istio_injection configured, but it's not set for the backstage namespace. If Istio is used in the cluster, consider whether the backstage namespace should also have this setting configured.
Let's check if other namespaces typically have istio_injection configured:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check istio_injection patterns across namespace definitions
# Expected: Consistent istio configuration across similar namespaces
# Search for namespace definitions with istio_injection
rg -t tf "kubernetes_engine_namespaces.*=.*\{" -A 10
Length of output: 54
Script:
#!/bin/bash
# Let's try different approaches to find namespace configurations and istio settings
# Search for namespace-related configurations
rg -t tf "namespace.*=.*{" -A 10
# Search specifically for istio injection configurations
rg -t tf "istio.*injection"
# Search for any kubernetes namespace resources
rg -t tf "resource.*kubernetes.*namespace"
# Look for tfvars files that might contain namespace configurations
fd -e tfvars -x cat {}
Length of output: 14415
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east4-a
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east1-b
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Main
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Main
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east1-b
GitHub Actions
Inactive
brettcurtis
temporarily deployed
to
Sandbox: Regional - us-east4-a
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
backstagenamespace entry in the configuration.remote_bucketvariable in multiple Terraform variable files for various environments.Documentation