Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_override_dir.jl: allow passing args to configure #1060

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

fingolfin
Copy link
Member

Also use that to treat warnings as error in some CI tests.

Also use that to treat warnings as error in some CI tests.
@fingolfin fingolfin force-pushed the mh/config-args-forsetup_override_dir branch from d087b6a to f5a40ea Compare October 24, 2024 21:33
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (5cbad84) to head (f5a40ea).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage   75.04%   75.55%   +0.50%     
==========================================
  Files          55       55              
  Lines        4556     4671     +115     
==========================================
+ Hits         3419     3529     +110     
- Misses       1137     1142       +5     

see 3 files with indirect coverage changes

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@lgoettgens
Copy link
Member

lgoettgens commented Oct 25, 2024

The failures:

@fingolfin fingolfin closed this Oct 28, 2024
@fingolfin fingolfin reopened this Oct 28, 2024
@fingolfin fingolfin enabled auto-merge (squash) October 28, 2024 14:30
@fingolfin fingolfin merged commit e9b89fc into master Oct 28, 2024
54 of 63 checks passed
@fingolfin fingolfin deleted the mh/config-args-forsetup_override_dir branch October 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants