Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding smart datetime #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

adding smart datetime #11

wants to merge 7 commits into from

Conversation

adavila0703
Copy link

No description provided.

@adavila0703 adavila0703 marked this pull request as draft December 18, 2024 04:57
@dillonstreator
Copy link
Contributor

dillonstreator commented Dec 18, 2024

I really like this smart date time input pattern but I'm questioning whether it makes sense for TTL where there are pretty strict rules around the maximum allowed duration (7 days) for both storage optimization reason as well as security. If the secret URLs are shared via an insecure channel, we don't want them to have super long ttls:
image

This component could however be valuable for the concept of 'delayed/deferred availability'. The thinking with this potential feature is that you could have an 'advanced configuration' (hidden in a dropdown - there's a handful of other features that I want in this dropdown already) wherein you specify a date at which point recipients are allowed to access the secret value. This smart date time input could make a lot of sense there but I still think we'd end up wanting some maximum allowed deferral date.

@adavila0703 adavila0703 marked this pull request as ready for review January 1, 2025 07:20
@adavila0703 adavila0703 requested review from dillonstreator and removed request for dillonstreator January 1, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants