Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: specfile #14

Closed
wants to merge 3 commits into from
Closed

package: specfile #14

wants to merge 3 commits into from

Conversation

supakeen
Copy link
Member

Provides a simplified version of the spec file and makefile included in osbuild-composer. Vendors existing dependencies, and enables CI (dependabot) to bump those.

@supakeen supakeen requested a review from thozza December 18, 2024 08:36
Vendor our dependencies, we use vendored dependencies for our RPM
builds.

Signed-off-by: Simon de Vlieger <[email protected]>
As we've now vendored our dependencies let's enable dependabot in the
same way we use it in our other Go projects.

Signed-off-by: Simon de Vlieger <[email protected]>
Provide a spec file for `image-builder-cli`. The spec file is based on
`osbuild-composer`'s spec file except it is simplified as (some)
usecases would currently cloud the intent of the specfile. We can add
back RHEL conditionals when/if we start shipping and building for RHEL.

Some tools from `osbuild-composer` are also included; most notably the
one that generates bundled dependencies from vendored modules.

Signed-off-by: Simon de Vlieger <[email protected]>
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A high level question/suggestion - can we just not include the vendor/ dir but instead make downloading/creating it part of the "make rpm" makefile? I would really like to try to avoid adding 1 million LoC if we can :)

@supakeen
Copy link
Member Author

supakeen commented Dec 18, 2024

A high level question/suggestion - can we just not include the vendor/ dir but instead make downloading/creating it part of the "make rpm" makefile? I would really like to try to avoid adding 1 million LoC if we can :)

The vendor directory needs to be part of our 'source distribution' which currently is a git checkout :)

We can do this locally but other tools that check out directly from git will still expect ./vendor to exist.

@schuellerf schuellerf mentioned this pull request Dec 18, 2024
@supakeen
Copy link
Member Author

Close in favor of #15.

@supakeen supakeen closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants